Closed
Conversation
erofs does not exist on SLES but it exists on Leap. As there is no sles_version macro available, this commit adds the requirement for the list of supported distros.
Collaborator
Author
|
@Conan-Kudo I could not find another way to exclude sles with regards to the way suse moves forwards on suse_version macro for sles/leap. Maybe you have a better idea |
Member
|
This PR doesn't matter since we don't build kiwi for Leap, only SLE. |
Member
|
This kind of functionality split is unacceptable. Either SUSE offers it in SLE or not. Since kiwi is part of SLE, we cannot use the |
Collaborator
Author
|
Hmm, ok then I have to solve this in https://github.com/SUSE/kiwi_sle16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
erofs does not exist on SLES but it exists on Leap. As there is no sles_version macro available, this commit adds the requirement for the list of supported distros.