Fix CS9113: Remove unused logger parameters in controllers#638
Fix CS9113: Remove unused logger parameters in controllers#638berezovskyi wants to merge 1 commit intomainfrom
Conversation
Removed the unused ILogger parameters from `ServiceProviderController`, `CatalogController`, and `ResourceController<T>` to eliminate the `CS9113: Parameter 'logger' is unread.` warning. Additionally updated `ChangeRequestController` and the documentation in `CatalogController` to match the changes. Co-authored-by: berezovskyi <64734+berezovskyi@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughFour ASP.NET Core controller classes have their constructor-based logger dependency injection removed, converting them from parameterized constructors to parameterless declarations. Method implementations and public endpoint behavior remain unchanged. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
=======================================
Coverage 50.86% 50.86%
=======================================
Files 174 174
Lines 10202 10202
Branches 1010 1010
=======================================
Hits 5189 5189
Misses 4756 4756
Partials 257 257 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This pull request removes unused
ILoggerparameter injections in various controllers to resolve theCS9113compiler warnings.The following files were modified:
OSLC4NetExamples.Server.NetCoreApi/Controllers/ServiceProviderController.csOSLC4NetExamples.Server.NetCoreApi/Controllers/CatalogController.csOSLC4NetExamples.Server.NetCoreApi/Controllers/Resources/ResourceController.csOSLC4NetExamples.Server.NetCoreApi/Controllers/Resources/ChangeRequestController.csThese controllers previously injected
ILoggerparameters through their primary constructors but never utilized them within the class logic. Their removal fixes the warnings and optimizes DI container resolution slightly by not fetching an unused logging instance.This change is safe because the parameters were entirely unused and does not alter the actual runtime behaviour of the application. The build and all non-server tests pass successfully without any regressions.
PR created automatically by Jules for task 5173446060881866056 started by @berezovskyi
Summary by CodeRabbit