Fix CS9113: Remove unused logger parameters in NetCoreApi examples#647
Fix CS9113: Remove unused logger parameters in NetCoreApi examples#647berezovskyi wants to merge 1 commit intomainfrom
Conversation
Removed unused `ILogger` parameters from the primary constructors of `CatalogController`, `ChangeRequestController`, `ResourceController`, and `ServiceProviderController` in the `OSLC4NetExamples.Server.NetCoreApi` project. This resolves multiple instances of compiler warning CS9113 (Parameter is unread). No new tests were added as this is a simple syntax cleanup. Code was formatted using `dotnet format`. Co-authored-by: berezovskyi <64734+berezovskyi@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughRemoved dependency injection of ILogger parameters from four controller classes in the Examples project. The controllers now use parameterless constructors without explicitly managing logger instances, simplifying class declarations while maintaining existing action method functionality. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can suggest fixes for GitHub Check annotations.Configure the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
=======================================
Coverage 50.86% 50.86%
=======================================
Files 174 174
Lines 10202 10202
Branches 1010 1010
=======================================
Hits 5189 5189
Misses 4756 4756
Partials 257 257 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
This PR addresses the compiler warning CS9113 ("Parameter 'logger' is unread") found across several classes in the
OSLC4NetExamples.Server.NetCoreApiproject. TheILoggerdependencies injected via primary constructors were never used in the bodies of the controllers.By removing these unused parameters, we eliminate the warnings and slightly simplify the Dependency Injection requirements for these example controllers.
dotnet formatwas run and tests pass.PR created automatically by Jules for task 4751829425066312682 started by @berezovskyi
Summary by CodeRabbit