Remove hardcoded condor/ directory in processing scripts#116
Draft
Remove hardcoded condor/ directory in processing scripts#116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do not know why this codebase requires everything to exist in a
condor/directory, and this PR is to get rid of that. This is very prevalent in our codebase, so I am setting this as a draft until it is complete.I think it will be impossible to get everything working 100%, mostly because I don't even know if the run 2 files exist anymore (I've looked for them). We can definitely implement this with the scripts we are running for run 3. Because of that, I see a few ways forward:
bkgdEstimation_2016.pyto work. I like this idea, because it allows us to rip out the bad code that has been written, but obviously it means stuff will be broken. However, I doubt any run 2 script actually works anymore, and we have a run 2 tag made.TODO List:
getHistfunctions to use filepathsgetYield,getIntegral, etc. because they aren't really useful