Skip to content

Remove hardcoded condor/ directory in processing scripts#116

Draft
lnestor wants to merge 1 commit intomasterfrom
remove-condor-directory-finally
Draft

Remove hardcoded condor/ directory in processing scripts#116
lnestor wants to merge 1 commit intomasterfrom
remove-condor-directory-finally

Conversation

@lnestor
Copy link
Contributor

@lnestor lnestor commented Feb 1, 2026

I do not know why this codebase requires everything to exist in a condor/ directory, and this PR is to get rid of that. This is very prevalent in our codebase, so I am setting this as a draft until it is complete.

I think it will be impossible to get everything working 100%, mostly because I don't even know if the run 2 files exist anymore (I've looked for them). We can definitely implement this with the scripts we are running for run 3. Because of that, I see a few ways forward:

  • Make the change and say screw it to all the old scripts that require the condor directory. Basically we don't worry about getting, say, bkgdEstimation_2016.py to work. I like this idea, because it allows us to rip out the bad code that has been written, but obviously it means stuff will be broken. However, I doubt any run 2 script actually works anymore, and we have a run 2 tag made.
  • (Current) Add deprecation notices to the old functions and fallback to the new functions.

TODO List:

  • Change the callers of these getHist functions to use filepaths
  • Get rid of getYield, getIntegral, etc. because they aren't really useful

@lnestor lnestor added the cleaup label Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant