Skip to content

Fix: correct validation data-flow wording (fix #82)#109

Open
Demiserular wants to merge 1 commit intoOWASP:masterfrom
Demiserular:fix/validation-backwards
Open

Fix: correct validation data-flow wording (fix #82)#109
Demiserular wants to merge 1 commit intoOWASP:masterfrom
Demiserular:fix/validation-backwards

Conversation

@Demiserular
Copy link

Hey , @PauloASilva

Issue #82 was NOT fixed in PR #108 - Line 105
still shows the backwards logic.

  • No code changes — documentation and formatting only.

Concerns :
This backwards statement teaches developers to validate outbound data instead of inbound user input and this may lead to:

  • Missing input sanitization
  • SQL injection vulnerabilities
  • XSS attacks
  • Command injection risks
  • This 5-year-old error will continue misleading developers learning Go security practices. Please keep an eye on these types of fixes.

I would love to work on more valuable issues , kindly mention few here.
Closes #82

@PauloASilva
Copy link
Collaborator

Hi @Demiserular,
Thanks for the PR.

Why did you feel the need to replace unordered list character from * to -?
If you check the other sections you'll see that * is used throughout the document what doesn't seem wrong according to John Gruber - one of Markdown authors.

On another note, additions are not the only form of contribution: I greatly appreciate help reviewing open PRs as well as leaving feedback on open issues.

Cheers,
Paulo A. Silva

@Demiserular
Copy link
Author

@PauloASilva honstly I just wanted to leave it for uniqueness and

  • Lines 117-118: Uniqueness check and Table look up check
  • Lines 128-144: Post-validation Actions section headers (Enforcement Actions, Advisory Action, Verification Action)
    although i can revert back to * if you say so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validation section fix

2 participants