Skip to content

Comments

Display model name used#705

Merged
northdpole merged 8 commits intomainfrom
update-vertex-prompt
Jan 27, 2026
Merged

Display model name used#705
northdpole merged 8 commits intomainfrom
update-vertex-prompt

Conversation

@robvanderveer
Copy link
Collaborator

Code was fully Cursor generated and reviewd by me

@PRAteek-singHWY
Copy link
Contributor

PRAteek-singHWY commented Jan 11, 2026

Hey @robvanderveer @northdpole 👋
I recently ran into the same recurring PYTHON_BLACK lint failures and opened PR #707 to standardize Python formatting using pre-commit.
I thought it might be helpful context here — please let me know if this looks like the right long-term approach or if you’d suggest adjustments.
Thanks as well — hitting this error after solid PR work made it clear this was worth fixing 🙂

@robvanderveer
Copy link
Collaborator Author

Thanks @PRAteek-singHWY, this is indeed a nuisance it seems.

@PRAteek-singHWY
Copy link
Contributor

Thanks @PRAteek-singHWY, this is indeed a nuisance it seems.

Thanks for confirming, @robvanderveer — appreciate it.

@northdpole
Copy link
Collaborator

Hey @robvanderveer @northdpole 👋 I recently ran into the same recurring PYTHON_BLACK lint failures and opened PR #707 to standardize Python formatting using pre-commit. I thought it might be helpful context here — please let me know if this looks like the right long-term approach or if you’d suggest adjustments. Thanks as well — hitting this error after solid PR work made it clear this was worth fixing 🙂

I'\d love for this to be pre-commit hooks, using it in the github ci can be a pain since in rare cases linting can produce non-functional code

We can easily make this pre-commit hooks using a pre-commit framework however, that'd be great

@PRAteek-singHWY
Copy link
Contributor

PRAteek-singHWY commented Jan 17, 2026

Hey @robvanderveer @northdpole 👋 I recently ran into the same recurring PYTHON_BLACK lint failures and opened PR #707 to standardize Python formatting using pre-commit. I thought it might be helpful context here — please let me know if this looks like the right long-term approach or if you’d suggest adjustments. Thanks as well — hitting this error after solid PR work made it clear this was worth fixing 🙂

I'\d love for this to be pre-commit hooks, using it in the github ci can be a pain since in rare cases linting can produce non-functional code

We can easily make this pre-commit hooks using a pre-commit framework however, that'd be great

@northdpole @robvanderveer Thanks for the feedback! I completely understand the concern about CI modifying code or breaking builds.

To address this, I’ve updated the PR to pivot to a local-only approach:

  1. Removed CI Enforcement: Deleted the GitHub Actions workflows (auto-format.yml, pre-commit-check.yml). This ensures zero risk to the CI pipeline and no automatic code changes.
  2. Kept Local Config: Retained .pre-commit-config.yaml so contributors can optionally use it to lint locally.
  3. 📝 Updated Documentation: Rewrote CONTRIBUTING.md to recommend pre-commit as a helpful local tool rather than a required CI step.

This creates a purely opt-in developer capability with no impact on the repository's build stability.

Ready for review!

PR -> #707

Signed-off-by: Spyros <northdpole@users.noreply.github.com>
Signed-off-by: Spyros <northdpole@users.noreply.github.com>
Signed-off-by: Spyros <northdpole@users.noreply.github.com>
Signed-off-by: Spyros <northdpole@users.noreply.github.com>
Signed-off-by: Spyros <northdpole@users.noreply.github.com>
@northdpole northdpole merged commit ccbc879 into main Jan 27, 2026
5 checks passed
@northdpole northdpole deleted the update-vertex-prompt branch January 27, 2026 15:58
PRAteek-singHWY pushed a commit to PRAteek-singHWY/OpenCRE that referenced this pull request Feb 14, 2026
* Update Vertex AI prompt formatting and structure for improved RAG

* fix(chatbot): update model reference from PALM2 to Gemini 2.0 Flash for improved accuracy

* feat(prompt-client): add model name retrieval methods and update chatbot to display model name

* Remove unnecessary blank line in vertex_prompt_client.py

Signed-off-by: Spyros <northdpole@users.noreply.github.com>

* Fix indentation in OpenAI prompt client

Signed-off-by: Spyros <northdpole@users.noreply.github.com>

* Fix formatting and whitespace in vertex_prompt_client.py

Signed-off-by: Spyros <northdpole@users.noreply.github.com>

* Format return statement for better readability

Signed-off-by: Spyros <northdpole@users.noreply.github.com>

---------

Signed-off-by: Spyros <northdpole@users.noreply.github.com>
Co-authored-by: Spyros <northdpole@users.noreply.github.com>
PRAteek-singHWY pushed a commit to PRAteek-singHWY/OpenCRE that referenced this pull request Feb 14, 2026
* Update Vertex AI prompt formatting and structure for improved RAG

* fix(chatbot): update model reference from PALM2 to Gemini 2.0 Flash for improved accuracy

* feat(prompt-client): add model name retrieval methods and update chatbot to display model name

* Remove unnecessary blank line in vertex_prompt_client.py

Signed-off-by: Spyros <northdpole@users.noreply.github.com>

* Fix indentation in OpenAI prompt client

Signed-off-by: Spyros <northdpole@users.noreply.github.com>

* Fix formatting and whitespace in vertex_prompt_client.py

Signed-off-by: Spyros <northdpole@users.noreply.github.com>

* Format return statement for better readability

Signed-off-by: Spyros <northdpole@users.noreply.github.com>

---------

Signed-off-by: Spyros <northdpole@users.noreply.github.com>
Co-authored-by: Spyros <northdpole@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants