Validation on first and last name according to EasyCredit model, static call fix, and add github workflow #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not extend oxid-tests
Contributor
|
@cgsmith : Thanks for the pull-request. I´ve create an intern ticket for review your request. If everything fine then we´ll integrate it with the next release v3.0.10 and we´ll taken over for OXID7 branch ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a lot of files changed here. The main parts are in added and removed. This could go in the next release.
The main issue fixed is it checks the name before sending to easycredit's API and follows their validation on the model.
The other changes are utilizing php-cs-fixer, adding a ide-helper file for local development, adding phpstan, adding phpunit
Added
Removed