Fixes some minor code issues

.gitignore

@@ -1 +1,2 @@
 *.kdev4
+build

src/CgStr.hpp

@@ -6,30 +6,31 @@
 #include <cassert>
 #include <ostream>
 #include <string>
+#include <utility>
 
 namespace synth {
 
-class CgStr {
+class CgStr final {
 public:
     CgStr(CXString&& s)
-        : m_data(s)
+        : m_data(std::move(s))
     { }
 
-    CgStr(CgStr&& other)
+    CgStr(CgStr&& other) noexcept
         : m_data(std::move(other.m_data))
     {
         other.m_data.data = nullptr;
     }
 
-    CgStr& operator=(CgStr&& other) {
+    CgStr& operator=(CgStr&& other) noexcept {
         destroy();
         m_data = std::move(other.m_data);
         other.m_data.data = nullptr; // HACK Undocumented behavior.
         assert(!other.valid());
         return *this;
     }
 
-    ~CgStr() {
+    ~CgStr() noexcept {
         destroy();
     }
 

src/FileIdSupport.hpp

@@ -3,6 +3,8 @@
 
 #include <clang-c/Index.h>
 #include <algorithm>
+#include <iterator>
+#include <functional>
 
 namespace std {
     template <>
@@ -30,7 +32,8 @@ namespace std {
             return std::equal(
                 std::begin(lhs.data),
                 std::end(lhs.data),
-                std::begin(rhs.data));
+                std::begin(rhs.data),
+                std::end(rhs.data));
         }
     };
 }

src/MultiTuProcessor.hpp

@@ -1,7 +1,7 @@
 #ifndef SYNTH_MULTI_TU_PROCESSOR_HPP_INCLUDED
 #define SYNTH_MULTI_TU_PROCESSOR_HPP_INCLUDED
 
-#include "fileidsupport.hpp"
+#include "FileIdSupport.hpp"
 #include "output.hpp"
 
 #include <boost/filesystem/path.hpp>
@@ -84,7 +84,7 @@ class MultiTuProcessor {
     // Common prefix of all keys in m_dirs
     fs::path m_rootInDir;
 
-    std::mutex m_mut;
+    mutable std::mutex m_mut;
 };
 
 } // namespace synth

src/annotate.cpp

@@ -3,7 +3,7 @@
 #include "CgStr.hpp"
 #include "MultiTuProcessor.hpp"
 #include "cgWrappers.hpp"
-#include "fileIdSupport.hpp"
+#include "FileIdSupport.hpp"
 #include "highlight.hpp"
 #include "output.hpp"
 #include "xref.hpp"

src/cgWrappers.hpp

@@ -12,23 +12,23 @@
 
 namespace synth {
 
-class CgTokensHandle {
+class CgTokensHandle final {
 public:
     CgTokensHandle(CXToken* data, unsigned ntokens, CXTranslationUnit tu_)
         : m_data(data), m_ntokens(ntokens), m_tu(tu_)
     {}
 
-    ~CgTokensHandle() { destroy(); }
+    ~CgTokensHandle() noexcept { destroy(); }
 
-    CgTokensHandle(CgTokensHandle&& other)
+    CgTokensHandle(CgTokensHandle&& other) noexcept
         : m_data(other.m_data)
         , m_ntokens(other.m_ntokens)
         , m_tu(other.m_tu)
     {
         other.release();
     }
 
-    CgTokensHandle& operator= (CgTokensHandle&& other)
+    CgTokensHandle& operator= (CgTokensHandle&& other) noexcept
     {
         destroy();
         m_data = other.m_data;
@@ -40,7 +40,7 @@ class CgTokensHandle {
 
     CXTranslationUnit tu() const { return m_tu; }
     unsigned size() const { return m_ntokens; }
-    CXToken* tokens() { return m_data; }
+    CXToken* tokens() const { return m_data; }
 
 private:
     void destroy()

src/cmdline.cpp

@@ -3,6 +3,7 @@
 #include <cstring>
 #include <stdexcept>
 #include <thread>
+#include <utility>
 
 using namespace synth;
 
@@ -77,7 +78,7 @@ CmdLineArgs CmdLineArgs::parse(int argc, char const* const* argv)
         throw std::runtime_error("Superfluous commandline arguments.");
 
     if (r.nThreads == 0)
-        r.nThreads = std::thread::hardware_concurrency();
+        r.nThreads = std::max(std::thread::hardware_concurrency(), 1u);
     for (auto& dir : r.inOutDirs) {
         if (!dir.second)
             dir.second = ".";

src/highlight.cpp

@@ -10,7 +10,7 @@
 using namespace synth;
 
 
-unsigned const kMaxRefRecursion = 16;
+static unsigned const kMaxRefRecursion = 16;
 
 static bool isTypeKind(CXCursorKind k)
 {