Open
Conversation
- moved to service worker for Chrome - polyfill removed as we didn't need it - instead added suggested workaround from https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/background#browser_support - manifest set to version 3 All in all this is once more a shitty situation: Chrome now requires Manifest v3 and only supports `service_worker` scripts for that, whereas Firefox doesn't support `service_worker` scripts yet and still depends on `background` scripts. Thankfully Chrome no longer seems to refuse extensions that contain a `background` script, it just ignores it. And Firefox ignores `service_worker`. Safari apparently supports both but prefers `service_worker`. In any case, I've rewritten the background script here to work as both and in both Chrome (`chrome.*`) and other browsers (`browser.*`). In other news, fsck Google, Chrome really is the new Internet Explorer...
Accidentally removed too much when getting rid of the polyfill.
And I'm pretty sure I installed it as such, but apparently not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring attempt for Manifest v3 support (and thus compatibility to current Chrome versions).
All in all this is once more a shitty situation: Chrome now requires Manifest v3 and only supports
service_workerscripts for that, whereas Firefox doesn't supportservice_workerscripts yet and still depends onbackgroundscripts. Thankfully Chrome no longer seems to refuse extensions that contain abackgroundscript, it just ignores it. And Firefox ignoresservice_worker. Safari apparently supports both but prefersservice_worker. In any case, I've rewritten the background script here to work as both and in both Chrome (chrome.*) and other browsers (browser.*). In other news, fsck Google, Chrome really is the new Internet Explorer...See #65. I tested this only locally, using an unpacked build, but that worked in both Chrome and Firefox. For easier testing by others I've also (hopefully) added a CI build.