Skip to content

feat: deprecate V1 tenant variables endpoints #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bec-callow-oct merged 1 commit into from
Jan 7, 2026
Merged

feat: deprecate V1 tenant variables endpoints #393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/tenants/tenant_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ func (s *TenantService) Clone(sourceTenant *Tenant, request TenantCloneRequest)
return resp.(*Tenant), nil
}

// Deprecated: Use UpdateProjectVariables and UpdateCommonVariables instead.
// This method will be removed in a future version.
Copy link
Contributor Author

@bec-callow-oct bec-callow-oct Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've discussed deprecating in 2027.1 - should I go ahead and commit to that here, or leave it open for now?

Copy link
Contributor

@benPearce1 benPearce1 Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just leave it open ended

func (s *TenantService) CreateVariables(tenant *Tenant, tenantVariable *variables.TenantVariables) (*variables.TenantVariables, error) {
resp, err := services.ApiAdd(s.GetClient(), tenantVariable, new(variables.TenantVariables), tenant.Links["Variables"])
if err != nil {
Expand Down Expand Up @@ -245,6 +247,8 @@ func (s *TenantService) GetByIdentifier(identifier string) (*Tenant, error) {
return s.GetByName(identifier)
}

// Deprecated: Use GetProjectVariables and GetCommonVariables instead.
// This method will be removed in a future version.
func (s *TenantService) GetVariables(tenant *Tenant) (*variables.TenantVariables, error) {
resp, err := api.ApiGet(s.GetClient(), new(variables.TenantVariables), tenant.Links["Variables"])
if err != nil {
Expand All @@ -271,6 +275,8 @@ func (s *TenantService) Update(resource *Tenant) (*Tenant, error) {
return resp.(*Tenant), nil
}

// Deprecated: Use UpdateProjectVariables and UpdateCommonVariables instead.
// This method will be removed in a future version.
func (s *TenantService) UpdateVariables(tenant *Tenant, tenantVariables *variables.TenantVariables) (*variables.TenantVariables, error) {
resp, err := services.ApiPost(s.GetClient(), tenantVariables, new(variables.TenantVariables), tenant.Links["Variables"])
if err != nil {
Expand Down
Loading