Skip to content

feat: Support custom AWS region for accounts #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bec-callow-oct merged 1 commit into from
Feb 18, 2026
Merged

feat: Support custom AWS region for accounts #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/accounts/account_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ type AccountResource struct {
Name string `json:"Name" validate:"required,notall"`
PrivateKeyFile *core.SensitiveValue `json:"PrivateKeyFile,omitempty"`
PrivateKeyPassphrase *core.SensitiveValue `json:"PrivateKeyPassphrase,omitempty"`
Region string `json:"Region,omitempty"`
ResourceManagerEndpoint string `json:"ResourceManagementEndpointBaseUri,omitempty"`
SecretKey *core.SensitiveValue `json:"SecretKey,omitempty"`
Slug string `json:"Slug,omitempty"`
Expand Down
4 changes: 4 additions & 0 deletions pkg/accounts/account_utilities.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ func ToAccount(accountResource *AccountResource) (IAccount, error) {
if err != nil {
return nil, err
}
amazonWebServicesAccount.Region = accountResource.Region
account = amazonWebServicesAccount
case AccountTypeAwsOIDC:
awsOIDCAccount, err := NewAwsOIDCAccount(accountResource.GetName(), accountResource.RoleArn)
Expand All @@ -31,6 +32,7 @@ func ToAccount(accountResource *AccountResource) (IAccount, error) {
}
awsOIDCAccount.RoleArn = accountResource.RoleArn
awsOIDCAccount.SessionDuration = accountResource.SessionDuration
awsOIDCAccount.Region = accountResource.Region
awsOIDCAccount.Audience = accountResource.Audience
awsOIDCAccount.DeploymentSubjectKeys = accountResource.DeploymentSubjectKeys
awsOIDCAccount.AccountTestSubjectKeys = accountResource.AccountTestSubjectKeys
Expand Down Expand Up @@ -149,10 +151,12 @@ func ToAccountResource(account IAccount) (*AccountResource, error) {
amazonWebServicesAccount := account.(*AmazonWebServicesAccount)
accountResource.AccessKey = amazonWebServicesAccount.AccessKey
accountResource.SecretKey = amazonWebServicesAccount.SecretKey
accountResource.Region = amazonWebServicesAccount.Region
case AccountTypeAwsOIDC:
awsOIDCAccount := account.(*AwsOIDCAccount)
accountResource.RoleArn = awsOIDCAccount.RoleArn
accountResource.SessionDuration = awsOIDCAccount.SessionDuration
accountResource.Region = awsOIDCAccount.Region
accountResource.Audience = awsOIDCAccount.Audience
accountResource.DeploymentSubjectKeys = awsOIDCAccount.DeploymentSubjectKeys
accountResource.AccountTestSubjectKeys = awsOIDCAccount.AccountTestSubjectKeys
Expand Down
1 change: 1 addition & 0 deletions pkg/accounts/amazon_web_services_account.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
type AmazonWebServicesAccount struct {
AccessKey string `json:"AccessKey" validate:"required"`
SecretKey *core.SensitiveValue `json:"SecretKey" validate:"required"`
Region string `json:"Region,omitempty"`

account
}
Expand Down
1 change: 1 addition & 0 deletions pkg/accounts/aws_oidc_account.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
type AwsOIDCAccount struct {
RoleArn string `json:"RoleArn"`
SessionDuration string `json:"SessionDuration,omitempty"`
Region string `json:"Region,omitempty"`
Audience string `json:"Audience,omitempty"`
DeploymentSubjectKeys []string `json:"DeploymentSubjectKeys,omitempty" validate:"omitempty,dive,oneof=space environment project tenant runbook account type'"`
HealthCheckSubjectKeys []string `json:"HealthCheckSubjectKeys,omitempty" validate:"omitempty,dive,oneof=space account target type'"`
Expand Down
Loading