Fixes for Windows demangling and file naming #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on OfekShilon#21 discussion. * add empty lock for windows and start a new demangler for each process. It is arguably not the worst solution even on other platforms, as Locks are not free, and for many files it is probably better to have demangler per process, rather than Lock them * replace \\ with in generated HTMLs, to produce correct filenames on windows
Owner
|
@AntonYudintsev thank you very much for this! As far as I can test - this is working properly. This is the 1st PR I'm merging into my own repo, and the GitHub UI seems to force me to associate my own user with the merge commit. I hope yours would appear in the right places in the files themselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #21 discussion.
add empty lock for windows and start a new demangler for each process. It is arguably not the worst solution even on other platforms, as Locks are not free, and for many files it is probably better to have demangler per process, rather than Lock them
replace \ with in generated HTMLs, to produce correct filenames on windows