Skip to content

logout + changePassword fix #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ggmartins wants to merge 5 commits into
base: master
Choose a base branch
from
Open

logout + changePassword fix #17

ggmartins wants to merge 5 commits into from

Conversation

@ggmartins
Copy link

@ggmartins ggmartins commented Jul 23, 2015

pom updates, logout, url route fixes, login, logout and changepassword fix

@OhadR
Copy link
Owner

OhadR commented Jul 24, 2015

thanks for your contribution!
several comments. the first one is about client/pom.xml: I think that the velocity and crypto dependencies are unnecessary, as they are already in the classpath (implicitly by the auth-flows/pom.xml, https://github.com/OhadR/oAuth2-sample/blob/master/authentication-flows/pom.xml#L25, https://github.com/OhadR/oAuth2-sample/blob/master/authentication-flows/pom.xml#L153)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggmartins @OhadR