[MarkdownAutoPreview] new markdownPreviewBuilder, textFieldBuilder and shouldInitTextField#3
Open
BugsOverBugs wants to merge 1 commit intoOmkarDabade:mainfrom
Open
[MarkdownAutoPreview] new markdownPreviewBuilder, textFieldBuilder and shouldInitTextField#3BugsOverBugs wants to merge 1 commit intoOmkarDabade:mainfrom
BugsOverBugs wants to merge 1 commit intoOmkarDabade:mainfrom
Conversation
…in MarkdownAutoPreview
OmkarDabade
requested changes
Sep 22, 2024
Owner
OmkarDabade
left a comment
OmkarDabade
left a comment
There was a problem hiding this comment.
Can you please create a new widget for this functionality
MarkdownAutoPreview is meant to show the preview automatically
Your case involves manual preview
It is better to create a new widget for this usecase
Author
|
Hi, the new fields are optional, so the original behavior remains with more flexibility. Unfortunately I don't have time to create a new widget. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I really appreciate your work on this package.
For my use case, I need the ability to use a custom text field and markdown preview, so I added builders for that.
I also added a new
boolto initiate theMarkdownAutoPreviewwith theTextField.Since you have disabled issues, I created this pull request.
Feel free to use the changes if you want.