Fixed draggable clone incorrect size#43
Open
GarethBlain wants to merge 8 commits intoOne-com:masterfrom
GarethBlain:master
Open
Fixed draggable clone incorrect size#43GarethBlain wants to merge 8 commits intoOne-com:masterfrom GarethBlain:master
GarethBlain wants to merge 8 commits intoOne-com:masterfrom
GarethBlain:master
Conversation
…ment (Issue 34) This only applies to the automatically generated clone element, not custom template elements. Original issue can be found here: #34
Currently if you start dragging a draggable element it adds the copy to the end of the parent which CAN change the size of the original object. Then we got the sizes of the original for the clone and it was wrong before making the clone actually popup (so it doesn't take space in the DOM). Could have been fixed by making it a popup (absolute position etc) before we got the sizes or simpler moved the appendChild command after we grab the sizes of the object. I can't see this causing any other issues.
CSS-class to identify zones that are possible to drop on on drag start.
…rt-mouse Position drag element relative to mousedown on original draggable ele…
…ct any tables it might be in Adding a new <TD> into a table makes most browsers add space for them even when they are floating with fixed positions...
…-position-wrt-mouse Revert "Position drag element relative to mousedown on original draggable ele…"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you start dragging a draggable element it adds the copy to the end of the parent which CAN change the size of the original object. Then we got the sizes of the original for the clone and it was wrong before making the clone actually popup (so it doesn't take space in the DOM).
Could have been fixed by making it a popup (absolute position etc) before we got the sizes or simpler moved the appendChild command after we grab the sizes of the object. I can't see this causing any other issues.