Open
Conversation
Wrong regexp was used so if iconv is not present then the tests fail.
Don't try to require iconv on browser environments in the first place. Not sure how to make iconv-lite properly configurable at runtime though.
Remove the need for a polyfill by providing an implementation that uses web APIs.
Allow passing an option to the decoder so that an unsupported charset throws an exception instead of silently decoding. Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional options struct that has a ignoreUnknownCharset boolean that is defaulted to true if the options aren't specified.
When false, if the charset isn't recognized then a RangeError exception is thrown.
This is PR #9 with one more commit on top (since PRs can't be set to merge into another PR and setting my forked branch as based would cause the PR to be in the wrong spot)