Skip to content

Conversation

@TheMeinerLP
Copy link
Collaborator

Proposed changes

This PR fixes some small isues with 1.21.4 client and via version.

Fixes ViaVersion/ViaVersion#4241

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Since 1.21.3 the client checks very persicily which tags are send and which are not.

In some cases the upstream forgot the tags or mapped wrong for the client. Also we found out, Velocity don't display such errors in the console only in the log, but that behavior can maybe only our problem because our "Cloud"-Solution.

@TheMeinerLP TheMeinerLP requested a review from a team as a code owner January 2, 2025 15:49
@github-actions github-actions bot added the Bugfix label Jan 2, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Copy link

@theEvilReaper theEvilReaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheMeinerLP TheMeinerLP merged commit 2335b0e into master Jan 2, 2025
5 of 7 checks passed
@TheMeinerLP TheMeinerLP deleted the bugfix/wrong-sended-game-and-biome-tags branch January 2, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.21.3 client can't join 1.21 minestom server

3 participants