Add PV panel equipment definition#8
Add PV panel equipment definition#8DougPlumley wants to merge 2 commits intoOntologyAlignmentProject:mainfrom
Conversation
annieDehghani
left a comment
annieDehghani
left a comment
There was a problem hiding this comment.
Looks like you're off to a good start! I added a few suggestions to help with conformance to our typical standards. Take a look and let me know if there are any questions.
| PVP: | ||
| name: Photovoltaic Panel | ||
| description: A collection of photovoltaic cells arranged into a panel to produce electrical energy. | ||
| brick_ontology: Photovoltaic Panel | ||
| attributes: | ||
| - ratedVoltage | ||
| - ratedCurrent | ||
| - ratedWattage |
There was a problem hiding this comment.
| PVP: | |
| name: Photovoltaic Panel | |
| description: A collection of photovoltaic cells arranged into a panel to produce electrical energy. | |
| brick_ontology: Photovoltaic Panel | |
| attributes: | |
| - ratedVoltage | |
| - ratedCurrent | |
| - ratedWattage | |
| PVP: | |
| name: Photovoltaic Panel | |
| description: A collection of photovoltaic cells arranged into a panel to produce electrical energy. | |
| brick_ontology: Photovoltaic Panel | |
| attributes: | |
| - ratedVoltage | |
| - ratedCurrent | |
| - ratedPower | |
| haystack: | |
| type: | |
| - equip | |
| - photovoltaic | |
| - panel |
In addition to having a unique OAP code as the key for each entity, we typically add a unique set of haystack tags to each entity. I suggest adding equip, photovoltaic (new tag that we are planning to use for PV-related entities) and panel.
| ratedWattage: | ||
| name: Rated Wattage | ||
| domain: electrical | ||
| haystack: | ||
| type: | ||
| - rated | ||
| - wattage | ||
| - attr | ||
| identification: | ||
| - kind: Number | ||
| unit_type: electric_wattage |
There was a problem hiding this comment.
| ratedWattage: | |
| name: Rated Wattage | |
| domain: electrical | |
| haystack: | |
| type: | |
| - rated | |
| - wattage | |
| - attr | |
| identification: | |
| - kind: Number | |
| unit_type: electric_wattage | |
| ratedPower: | |
| name: Rated Power | |
| domain: electrical | |
| haystack: | |
| type: | |
| - rated | |
| - power | |
| - attr | |
| identification: | |
| - kind: Number | |
| unit_type: power |
This is a great attribute to add as it comes up in many contexts beyond just PV panels. I suggest using the term "Power" to describe this attribute rather than wattage as it may have different units in different contexts. Additionally I would use the power tag since that's an existing tag in OAP. Lastly, the unit_type should align with the units types in field.units.yaml so I would use power as the unit_type here.
|
Hi @annieDehghani, your suggested changes look great, apologizes in the delay responding. Thanks! |
2 participants
Hi,
@baricker and I worked on this with the team to come up with a simple definition for a PV panel, see #7.
This is our first exercise working with metadata tagging and we recognize this definition isn't fully fleshed out, so please comment/update as needed.
Thanks!