This repository was archived by the owner on Oct 1, 2025. It is now read-only.
feat: added adr for burning or tterc721 token#26
Open
Conversation
rjchow
reviewed
Oct 20, 2020
| } | ||
| ``` | ||
|
|
||
| However, TradeTrust is still required to render and track burnt token. Since unminted tokens and destoryed token have the same owner address in the Erc721 Token Registry, we needed to find a way to differentiate a unminted and burnt token. This means that TradeTrust would have to modify the ERC721 implementation or modify its verifier method. |
Contributor
There was a problem hiding this comment.
Suggested change
| However, TradeTrust is still required to render and track burnt token. Since unminted tokens and destoryed token have the same owner address in the Erc721 Token Registry, we needed to find a way to differentiate a unminted and burnt token. This means that TradeTrust would have to modify the ERC721 implementation or modify its verifier method. | |
| In the TradeTrust application, tokens are still required to be traceable and viewable after destruction. Since unminted tokens and burnt token appear to have the same owner address (.ownerOf() throws error 'cannot query non-existent token') in the ERC721 Token Registry, it is necessary to find a way to differentiate an unminted and burnt token. | |
| There exists two broad approaches to resolve this: | |
| 1. The ERC721 implementation is modified to support the additional state of 'destroyed' | |
| 1. The verification method in OpenAttestation or TradeTrust is modified to detect the history of the token, if any exists |
| - event emission might be lost in future | ||
| - state is not immediately available to be queried (as both unminted token and burnt tokens had `0x0` address, thus we need to query events) | ||
|
|
||
| #### using 0xknown as burn address (like [0x000000000000000000000000000000000000dead](https://etherscan.io/address/0x000000000000000000000000000000000000dead)) |
Contributor
There was a problem hiding this comment.
Suggested change
| #### using 0xknown as burn address (like [0x000000000000000000000000000000000000dead](https://etherscan.io/address/0x000000000000000000000000000000000000dead)) | |
| #### using a known address as a burn address (e.g [0x000000000000000000000000000000000000dead](https://etherscan.io/address/0x000000000000000000000000000000000000dead)) |
|
|
||
| #### using 0xknown as burn address (like [0x000000000000000000000000000000000000dead](https://etherscan.io/address/0x000000000000000000000000000000000000dead)) | ||
|
|
||
| This method instead would see that the token would be burn to `0xdead` address, a known burn address which no one has the keys for. Subsequently, in order to track the token, we will need to check the `ownerOf` token from the token registry. |
Contributor
There was a problem hiding this comment.
Suggested change
| This method instead would see that the token would be burn to `0xdead` address, a known burn address which no one has the keys for. Subsequently, in order to track the token, we will need to check the `ownerOf` token from the token registry. | |
| This method instead would see that the token would be burn to `0xdead` address, a known burn address that there is an extremely infinitesimal chance anyone has the keys to. Subsequently, in order to track the token, we will need to check the `ownerOf` token from the token registry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds decision records of burning
TradeTrustErc721token to0xdeadinstead if0x0.