Added break feature to calendar #607
Open
+308
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created breaks on the OCS dashboard calendar. When you click on an event and put in a name and description, you have the option to make the date a break. When you make the break, it displays the break as a cell that covers the entire date, along with text that says "Break: [name of break]". When you click on the name of the break, you can edit or delete the break as you would for an event. When you click anywhere on the cell except for the name of the break, it tells you that a break is declared and you cannot add an event for that day. Also, when a break is created, any events for that day are moved to the next day that doesn't have a break.
Additionally there was an issue with editing events, where it would make a new event every time you tried to edit an event and save changes, and I fixed it. Also, I had re-added the getAssignments function by accident, and made sure to get rid of all instances of it in calendar.md.
These are my changes for the pages repo; I PR'd separate changes for the spring repo regarding break functionality.