fix: remove stale health-gate args and add done-gate passthrough in core4_eval.py#111
Merged
fix: remove stale health-gate args and add done-gate passthrough in core4_eval.py#111
Conversation
…ore4_eval.py The core4_eval.py was passing --transport-error-threshold, --health-samples, --health-min-success, and --health-sample-delay to run_dc_eval.py, but those args don't exist in run_dc_eval.py (they were from uncommitted Codex changes). Also adds --done-gate passthrough to match PR #110. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--transport-error-threshold,--health-samples,--health-min-success,--health-sample-delayfrom core4_eval.py — these args don't exist in run_dc_eval.py and causeunrecognized argumentserrors--done-gate,--done-gate-max-overrides,--done-gate-thresholdpassthrough to match PR feat: add done-gate to prevent premature task completion #110Test plan
uv run python scripts/core4_eval.py run --trials 1 --controller --done-gate --max-steps 30 --vm-ip 172.173.66.131 --dry-runsucceeds🤖 Generated with Claude Code