fix: use WAA server for /evaluate instead of fragile socat proxy#115
Merged
fix: use WAA server for /evaluate instead of fragile socat proxy#115
Conversation
The evaluate endpoint (/evaluate) is already available on the WAA Flask server (port 5000), which is accessed via a single reliable SSH tunnel (local:5001 → VM:5000). The separate evaluate chain (local:5050 → VM:5051 → socat → docker exec → container:5050) was fragile and caused infrastructure failures when socat died mid-trial. Changes: - Default --evaluate-url to None (falls back to --server URL) - Remove socat proxy setup (_setup_eval_proxy) from run_dc_eval.py - Remove port 5050 from SSH tunnel forwarding - Make done-gate non-fatal when evaluate returns infrastructure error - All scripts pass --evaluate-url only when explicitly set Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/evaluateendpoint is already available on the WAA Flask server (port 5000), accessed via a single reliable SSH tunnel (local:5001 → VM:5000)local:5050 → VM:5051 → socat → docker exec → container:5050) was fragile — socat died mid-trial causing 6/7 infrastructure failures in Core4 Trial 1--evaluate-urltoNoneso it falls back to--serverURL (one port, one tunnel, no socat)_setup_eval_proxy()and port 5050 SSH tunnel fromrun_dc_eval.pyRoot cause analysis
The Codex session (commit
9071fca) completed all 40 runs because the socat proxy happened to stay alive. Our trial (HEAD) had 6/7 infra failures because socat died mid-run. The evaluate code itself is identical between versions — the fragile proxy chain was the sole cause.Port 5050 inside the container is the same Flask app as port 5000 (confirmed:
curl http://localhost:5050/probereturns 200). There is no reason to maintain a separate proxy chain.Test plan
🤖 Generated with Claude Code