Skip to content

Conversation

@Cadair
Copy link
Member

@Cadair Cadair commented Feb 6, 2025

This should fix #78

@Cadair
Copy link
Member Author

Cadair commented Feb 6, 2025

@jgieseler can you test this?

@jgieseler
Copy link
Contributor

Yes, seems to work!

I downloaded the updated version and run cookiecutter packaging-guide-main -o ./output_directory. Now the result after installation when running pip uninstall jan looks like this:

Found existing installation: jan 0.1.dev0+d20250206
Uninstalling jan-0.1.dev0+d20250206:
  Would remove:
    /Users/gieseler/miniforge3/envs/testenv/bin/open_astronomy_package_template_example
    /Users/gieseler/miniforge3/envs/testenv/lib/python3.11/site-packages/jan-0.1.dev0+d20250206.dist-info/*
    /Users/gieseler/miniforge3/envs/testenv/lib/python3.11/site-packages/jan/*
Proceed (Y/n)? n

I assume the bin open_astronomy_package_template_example should be there (it was the same before)?

@Cadair
Copy link
Member Author

Cadair commented Feb 6, 2025

@Cadair Cadair merged commit 9614931 into main Feb 6, 2025
7 checks passed
@Cadair Cadair deleted the packages-find branch February 6, 2025 13:42
CyclingNinja pushed a commit to CyclingNinja/packaging-guide that referenced this pull request Sep 2, 2025
This is an autogenerated PR, which updates the `{{
cookiecutter.package_name }}/.pre-commit-config.yaml` file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some subfolders end up in the site-packages main folder (instead of package subfolder)

3 participants