Skip to content

Fix various issues, improve log messages, update documentation, and add regression tests#126

Merged
davidallendj merged 15 commits intomainfrom
allend/fix-issues
Feb 9, 2026
Merged

Fix various issues, improve log messages, update documentation, and add regression tests#126
davidallendj merged 15 commits intomainfrom
allend/fix-issues

Conversation

@davidallendj
Copy link
Collaborator

@davidallendj davidallendj commented Oct 8, 2025 •
edited
Loading

Pull Request Template

Thank you for your contribution! Please ensure the following before submitting:

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Description

This PR adds documentation that about using --insecure with scan after changing the default value to false. It also adds more log messages to find these related issues and fixes an issue related to closing the secrets file too early, and adds regression tests.

Additionally, this adds SerialConsole and CommandShell to the output of the crawler.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

For more info, see Contributing Guidelines.

@davidallendj davidallendj marked this pull request as draft October 8, 2025 18:48
@davidallendj
Copy link
Collaborator Author

davidallendj commented Oct 8, 2025

Still need to add the regression tests before merging.

@davidallendj davidallendj marked this pull request as ready for review February 5, 2026 17:01
@davidallendj
chore: minor changes and added debug prints
6f2ca76 
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
@davidallendj
fix: issue with chassis/system merge not working
7bea6f9 
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
@davidallendj
docs: added info about using --insecure with scan
2502d7d 
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
@davidallendj
chore: improved log messages
bd83ac9 
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
@davidallendj
fix: issue with secrets file closing too early
d99cf5f 
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
@davidallendj
chore: updated changelog
af53740 
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
@davidallendj
refactor: removed unused flags and added --insecure to collect
d554dac 
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
@davidallendj
chore: updated go deps
6c06185 
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
@davidallendj
refactor: added precondition for scan implementation
33431bc 
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
@davidallendj
refactor: changed how files are closed
8291ccb 
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
@davidallendj
refactor: updated test implementations
c8c5c39 
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
@davidallendj
refactor: minor formatting changes
1fc9d8d 
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
@davidallendj
refactor: minor changes to debug messages
ec94740 
Signed-off-by: David J. Allen <davidallendj@gmail.com>
Signed-off-by: David Allen <davidallendj@gmail.com>
@davidallendj
refactor: changed status code string
633be66 
Signed-off-by: David Allen <davidallendj@gmail.com>
@davidallendj
feat: added serial console and command shell to output
4d188cf 
Signed-off-by: David Allen <davidallendj@gmail.com>
cjh1
cjh1 reviewed Feb 6, 2026
View reviewed changes
Copy link
Member

@cjh1 cjh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

pkg/crawler/main.go
IPMI SerialConsoleConfig `json:"impi,omitempty"`
Telnet SerialConsoleConfig `json:"telnet,omitempty"`
SSH SerialConsoleConfig `json:"ssh,omitempty"`
}
Copy link
Member

@cjh1 cjh1 Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ther is also support for websocket console in RF, the remote console service currently doesn't support it, but we might want to add it here for completeness, not sure if gofish supports it?

Copy link
Collaborator Author

@davidallendj davidallendj Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking for it but I'm not seeing it from the library. I'll look upstream to see if it was added recently.

Copy link
Collaborator Author

@davidallendj davidallendj Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it here, but I guess it hasn't been merged yet?

Copy link
Member

@cjh1 cjh1 Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange I didn't think it was that new, for now I guess be an punt on supporting it.

Copy link
Collaborator Author

@davidallendj davidallendj Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it may just be that they haven't done a new release yet. Whenever, that happens we can add support for it.

Copy link
Collaborator Author

@davidallendj davidallendj Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it may just be that they haven't done a new release yet. Whenever, that happens we can add support for it.

Copy link
Contributor

@synackd synackd Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be prudent to start a branch that uses a replace directive in go.mod to redirect to the branch version, removing it and creating a PR for the branch once support is merged. That way, the functionality can be implemented without having to wait.

bmcdonald3
bmcdonald3 approved these changes Feb 9, 2026
View reviewed changes
Copy link
Member

@bmcdonald3 bmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

synackd
synackd reviewed Feb 9, 2026
View reviewed changes
@davidallendj davidallendj merged commit ca84ebe into main Feb 9, 2026
5 checks passed
@davidallendj davidallendj deleted the allend/fix-issues branch February 9, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@synackd synackd synackd left review comments

@bmcdonald3 bmcdonald3 bmcdonald3 approved these changes

@cjh1 cjh1 Awaiting requested review from cjh1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidallendj @cjh1 @synackd @bmcdonald3