ready to be tested in the framework#2
Open
ssafaei wants to merge 8 commits intoOpenCMISS-Examples:developfrom
ssafaei:develop
Open
ready to be tested in the framework#2ssafaei wants to merge 8 commits intoOpenCMISS-Examples:developfrom ssafaei:develop
ssafaei wants to merge 8 commits intoOpenCMISS-Examples:developfrom
ssafaei:develop
Conversation
hsorby
reviewed
Feb 11, 2018
Member
hsorby
left a comment
hsorby
left a comment
There was a problem hiding this comment.
Why do you have both expected_results and output directories?
Contributor
Author
|
When we run the example, OpenCMISS writes the results into the output folder, instead of spreading it in the main folder. The expected_results is for the testing framework to compare it with. |
Member
|
Yes, so we don't want the generated output in the repository. |
hsorby
requested changes
Feb 11, 2018
Member
hsorby
left a comment
hsorby
left a comment
There was a problem hiding this comment.
Documentation in the README.rst needs to be written for this example.
Member
|
Does this example run with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.