Skip to content

[backend/frontend] add new action types for handling users in background tasks (#3343)#11601

Merged
Gwendoline-FAVRE-FELIX merged 40 commits intomasterfrom
issue/3343
Jul 24, 2025
Merged

[backend/frontend] add new action types for handling users in background tasks (#3343)#11601
Gwendoline-FAVRE-FELIX merged 40 commits intomasterfrom
issue/3343

Conversation

@JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Jul 4, 2025

Proposed changes

  • moved Users and Users in organization to DataTable
  • added mass operation on users

client PR: OpenCTI-Platform/client-python#932

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jul 4, 2025
@JeremyCloarec JeremyCloarec added the multi-repository For contribution that requires PR in several repository label Jul 4, 2025
@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 49.36709% with 40 lines in your changes missing coverage. Please review.

Project coverage is 67.07%. Comparing base (fc1e278) to head (a04548a).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
...pencti-graphql/src/domain/backgroundTask-common.js 23.33% 23 Missing ⚠️
...latform/opencti-graphql/src/manager/taskManager.js 37.50% 15 Missing ⚠️
...pencti-platform/opencti-graphql/src/domain/user.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11601      +/-   ##
==========================================
+ Coverage   65.14%   67.07%   +1.92%     
==========================================
  Files         727      728       +1     
  Lines       72289    73145     +856     
  Branches     7918     9657    +1739     
==========================================
+ Hits        47096    49062    +1966     
+ Misses      25193    24083    -1110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JeremyCloarec JeremyCloarec changed the title [backend] add new action types for handling users in background tasks [backend/frontend] add new action types for handling users in background tasks (#3343) Jul 8, 2025
@JeremyCloarec JeremyCloarec marked this pull request as ready for review July 17, 2025 12:51
@lndrtrbn lndrtrbn requested a review from delemaf July 18, 2025 08:12
Copy link
Member

@delemaf delemaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good overall but little front-end fix need to be done

>

<DataTableToolBar
isUserDatatable={isUserDatatable}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like that. This is for customization of the toolbar, we need to find a more generic way.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taskScope is now used

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX merged commit 7c05b9c into master Jul 24, 2025
12 checks passed
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX deleted the issue/3343 branch July 24, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team multi-repository For contribution that requires PR in several repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants