Fix linux electron sandbox #25
Merged
+34
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 3, 2026 11:20
… step for macOS CI - Add libx11-dev and libx11-xcb-dev to Linux test workflow to fix native-keymap build failure - Add missing 'Install build dependencies' step to macOS test workflow to ensure build/ folder dependencies are installed before main dependencies
…eaks The clear() method was not disposing of currentDisposables, which contained KeybindingLabel instances. When render() was called multiple times, these disposables would accumulate and cause memory leaks in tests. Now clear() properly disposes of all currentDisposables before clearing them, ensuring KeybindingLabel instances are properly cleaned up.
The Electron SUID sandbox helper binary needs to be owned by root and have mode 4755 to work properly on Linux. This step configures the sandbox permissions after Electron is downloaded, matching the Azure Pipelines configuration.
Remote integration tests also use Electron and require the chrome-sandbox to be configured. Updated the condition to run the sandbox configuration step for both electron_tests and remote_tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.