feat: Recovery/custom question types 20260224#355
Open
najuna-brian wants to merge 8 commits intoOpenDataEnsemble:devfrom
Open
feat: Recovery/custom question types 20260224#355najuna-brian wants to merge 8 commits intoOpenDataEnsemble:devfrom
najuna-brian wants to merge 8 commits intoOpenDataEnsemble:devfrom
Conversation
Signed-off-by: Jessie Ssebuliba <jessiessebuliba@gmail.com>
Replace dynamic import() of file:// URIs with a sandboxed evaluation
approach for custom question type modules.
Security:
- Add CustomQuestionTypeScanner (RN side) that reads index.js files as
strings and screens them against a blocklist (fetch, XMLHttpRequest,
eval, document.cookie, localStorage, etc.)
- Rewrite CustomQuestionTypeLoader (WebView side) to evaluate source
in a scoped sandbox via new Function(), exposing only React and MUI
- Manifest shape changed from { modulePath: string } to { source: string }
New files:
- formulus/src/services/CustomQuestionTypeScanner.ts
- formulus-formplayer/src/services/CustomQuestionTypeLoader.ts (rewritten)
- formulus-formplayer/src/services/CustomQuestionTypeRegistry.ts
- formulus-formplayer/src/renderers/CustomQuestionTypeAdapter.tsx
- formulus-formplayer/src/types/CustomQuestionTypeContract.ts
- formulus-formplayer/docs/custom-question-types-architecture.md
Modified files:
- formulus/src/components/FormplayerModal.tsx (calls scanner)
- FormulusInterfaceDefinition.ts (both projects, modulePath → source)
- formulus-formplayer/src/App.tsx (orchestration)
Signed-off-by: Jessie Ssebuliba <jessiessebuliba@gmail.com>
najuna-brian
changed the title
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovery/custom question types 20260224