traj: allow specifying the trajectory, observation and time dimensions/variables#149
Open
gauteh wants to merge 1 commit intoOpenDrift:mainfrom
Open
traj: allow specifying the trajectory, observation and time dimensions/variables#149gauteh wants to merge 1 commit intoOpenDrift:mainfrom
gauteh wants to merge 1 commit intoOpenDrift:mainfrom
Conversation
…s/variables Not 100% sure if this is necessary. I was trying to avoid the problem where there's another dimension to time (say 'campaign'), but that's another issue. This is mostly to allow users to specify the dimensions manually when there is ambiguity. Maybe it would be better to allow specifying the longitude and latitude variables (e.g. in the case when there are interpolated values for the IMU, sometimes you want one, sometimes the other).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not 100% sure if this is necessary. I was trying to avoid the problem
where there's another dimension to time (say 'campaign'), but that's
another issue. This is mostly to allow users to specify the dimensions
manually when there is ambiguity. Maybe it would be better to allow
specifying the longitude and latitude variables (e.g. in the case when
there are interpolated values for the IMU, sometimes you want one,
sometimes the other).