-
Notifications
You must be signed in to change notification settings - Fork 2
feat(action-list): allow specification of action-list row height and improve spacing #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(action-list): allow specification of action-list row height and improve spacing #6
Conversation
6cef6cb to
a0f506a
Compare
|
I would be grateful for a review and/or discussion on this |
a0f506a to
cff94f7
Compare
cff94f7 to
7f0dcda
Compare
|
More updates on this PR soon! Don't look yet 😉 @ca-d helped me improve it muchly and tomorrow I will update and add some commentary. |
…improve spacing (closes OpenEnergyTools#5)
7f0dcda to
31260d2
Compare
|
We've added some:
I'd be grateful for a review at an appropriate time. |
… by supporting text
|
Hi Dan, I think it look promising. I just did scope thie element and added visual regresion test to run on a PR. I would ask you taking over the changes into the new main and let the github action generate the new screenshots. Sorry for the unconvinience. I want though to have that feature in. |
|
Does this PR solve you problems with the different list element hights? |
I have merged it (it wasn't clean so I had to do somewhat by hand, hopefully without error). Nice to see your new scoped components and the approach there.
Yes, I think this will keep the heights correct. |
8625a7e to
da86815
Compare
da86815 to
4460c9a
Compare
|
Just to note that I've removed open-scd theme styling as requested and included the artifacts from the CI pipeline. Thanks for the (in-person) review. |
Closes #5
This is a "cheap and cheerful" fix.
We:
I don't think this will terribly break compatibility with other uses but please consider this.
I will update the PR aligned with this in oscd-publisher OpenEnergyTools/oscd-publisher#7 and provide some screenshots for assessment so that with an
npm linkit can be examined more closely