Conversation
Deploying geoinsight with
|
| Latest commit: |
7691dc5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2b7e07d0.geoinsight.pages.dev |
| Branch Preview URL: | https://views.geoinsight.pages.dev |
Deploying geodatalytics with
|
| Latest commit: |
9869dde
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://76b9d192.geodatalytics.pages.dev |
| Branch Preview URL: | https://views.geodatalytics.pages.dev |
BryonLewis
requested changes
Mar 2, 2026
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
Mostly it seems to work, most of my comments are about structure (maybe weird auto-formatting) and some structure (mixed .then async await)
There are several instances of components in templates having their properties squished into multiple per line. Was this intentional and how you want components specified going forward?
One question about the stored point not being properly editable in the admin interface because coordinates are reversed
Theme saving doesn't adjust the vuetify theme it will change the map theme but not vuetify components.
brianhelba
reviewed
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #299.
Resolves #73.
This PR creates a new model
ViewStateand adds a menu for saving/loading ViewStates to theControlsBarcomponent.When the user selects a view state from this list, the window will be redirected to
/view/{id}and the view state will be loaded from the url. The user may refresh the page or send the link to a collaborator and the same UI state will be loaded. Therefore, the view states listed in the menu each have a "copy shareable link" button to the side.When the user clicks the "Save Current View State" button, this dialog appears:
