Ignore complexity violations, but re-enable rules#315
Merged
brianhelba merged 2 commits intomasterfrom Mar 5, 2026
Merged
Conversation
brianhelba
commented
Mar 5, 2026
| geodata = geopandas.GeoDataFrame.from_features( | ||
| vector_data.read_geojson_data().get("features") | ||
| ).set_crs(4326) | ||
| geodata = geodata.fillna({"connection_column": ""}) |
Collaborator
Author
There was a problem hiding this comment.
Note, this is a semantic change, removing inplace=True, due to https://docs.astral.sh/ruff/rules/pandas-use-of-inplace-argument/
Collaborator
Author
|
With the exception of 1 thing noted as an inline comment, the rest of the refactor is just structural (moving functions and inlining variables) and should have no behavior impact. |
Deploying geodatalytics with
|
| Latest commit: |
45fab6a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5565b44b.geodatalytics.pages.dev |
| Branch Preview URL: | https://noqa-ruff-errors.geodatalytics.pages.dev |
brianhelba
force-pushed
the
noqa-ruff-errors
branch
from
2ccbcd0 to
45fab6a
Compare
annehaley
approved these changes
Mar 5, 2026
Collaborator
annehaley
left a comment
annehaley
left a comment
There was a problem hiding this comment.
This seems like a fairly straightforward refactor. Thank you for pointing out the one semantic change. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also refactor some functions to reduce complexity.