Fix issue with screenshot size#114
Open
scottwittenburg wants to merge 1 commit intoOpenImaging:masterfrom
Open
Fix issue with screenshot size#114scottwittenburg wants to merge 1 commit intoOpenImaging:masterfrom
scottwittenburg wants to merge 1 commit intoOpenImaging:masterfrom
Conversation
|
@scottwittenburg I've pulled and tried this on our integration environment. I've tried resizing my browser and taking various screen shots, and it's still sending images larger than 512x512 px. |
Collaborator
Author
|
@jimklo That's because it depends on a change in vtk.js which isn't merged yet. As I mentioned in the description, we need that to get merged and generate a new version, then we can bump our dependency on vtk.js to pick it up. I changed this to a draft. |
15ce1ff to
7911f44
Compare
dzenanz
approved these changes
May 21, 2021
Member
dzenanz
left a comment
There was a problem hiding this comment.
I guess this should now be working?
Contributor
|
@dchiquito could you look over at this issue with help from @scottwittenburg and @dzenanz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Currently just fixes the captured screenshot size at
512x512, but could be extended in the future to allow the user to specify an arbitrary size. Depends on this PR getting merged into vtk.js, then we can bump the version we depend on here.Fixes #99