refactor: Refactor to improve comments and reduce code duplication#169
Merged
mwiebe merged 1 commit intoOpenJobDescription:mainlinefrom Feb 14, 2025
Merged
Conversation
mwiebe
force-pushed
the
comment-error-improvements
branch
2 times, most recently
from
d0e36cf to
e8accd2
Compare
leongdl
reviewed
Feb 14, 2025
leongdl
previously approved these changes
Feb 14, 2025
jusiskin
previously approved these changes
Feb 14, 2025
* Comments are more clear about difference between model parsing, when values may not be available, and job instantiation, when all values must be available for format strings. * Created a new file to hold general validator functions for some commonly used patterns. * Adjust the model to reduce the number of confusingly spurious errors, like when errors include "must be int" and "must be string" for the exact same field, seemingly contradictory errors. Signed-off-by: Mark Wiebe <399551+mwiebe@users.noreply.github.com>
mwiebe
force-pushed
the
comment-error-improvements
branch
from
e8accd2 to
41c4bfb
Compare
mwiebe
changed the title
|
leongdl
approved these changes
Feb 14, 2025
jusiskin
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Improvements following up from #168,
and other cleanup/code duplication reduction.
What was the solution? (How)
What is the impact of this change?
Better experience with the code base and the error messages.
How was this change tested?
Ran the unit tests.
Was this change documented?
Code comments improved.
Is this a breaking change?
No.
Does this change impact security?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.