fix: handle trailing slashes in example test runner#117
Merged
crowecawcaw merged 1 commit intoOpenJobDescription:mainlinefrom Mar 16, 2026
Merged
fix: handle trailing slashes in example test runner#117crowecawcaw merged 1 commit intoOpenJobDescription:mainlinefrom
crowecawcaw merged 1 commit intoOpenJobDescription:mainlinefrom
Conversation
Signed-off-by: Stephen Crowe <6042774+crowecawcaw@users.noreply.github.com>
mwiebe
approved these changes
Mar 16, 2026
crowecawcaw
merged commit 47a470f
into
OpenJobDescription:mainline
2 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the example test runner, when a trailing slash was included in the test pattern argument (e.g.,
2023-09/EXPR/), the path split produced an empty string for the test type filter, causingfnmatchto match zero test directories and silently reporting 0 passed, 0 failed. This was confusing because the same pattern without the trailing slash worked correctly. Fixed by stripping trailing slashes from the pattern before splitting it into parts.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.