Skip to content

Add dbt-run and dbt-version facets validation #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LegendPawel-Marut wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add dbt-run and dbt-version facets validation #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions producer/dbt/runner/openlineage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
transport:
type: file
log_file_path: ../events/openlineage_events.jsonl
append: true
log_file_path: ../output/events.jsonl
append: true
6 changes: 2 additions & 4 deletions scripts/validate_ol_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,15 @@ def is_custom_facet(facet, schema_type):
if facet.get('_schemaURL') is not None:
is_custom = any(facet.get('_schemaURL').__contains__(f'defs/{facet_type}Facet') for facet_type in
['Run', 'Job', 'Dataset', 'InputDataset', 'OutputDataset'])
is_common = any(facet.get('_schemaURL').__contains__(f'schema/{facet_type}-facet.json') for facet_type in
['dbt-version-run', 'dbt-run-run'])
if is_custom or is_common:
if is_custom:
print(f"facet {schema_type} seems to be custom facet, validation skipped")
return True
return False

@staticmethod
def is_facet(path):
# List of facets from the common package that can be used for syntax validation
common_facets = ['dbt-node-job-facet.json']
common_facets = ['dbt-node-job-facet.json','dbt-version-run-facet.json','dbt-run-run-facet.json']
return 'Facet.json' in path or path in common_facets

@classmethod
Expand Down
Loading