Update override handling #402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pylint is recommenting to order the imports in several sections alphabetically: (1) python standard library (2) third party packages (3) current package
Would it make sense to combine this code and the code in linearize() in one new function? def _process_override_data(self, om_cmd, sim_override, file_override) -> None: The code could: (1) check the version; set command line parameters as needed (2) create the content of the override file (3) create the overwrite file and set it as command line parameter The advantage would be, that the modified code is not in two places but only in one ...
…ons as dict[str, str] * after OMC is run, the values will be string anyway * simplify code / align on one common definition for these dicts
This was referenced Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update of PR #400 based on my comments:
import reto the right point__init__())def _process_override_data()This needed some cleanup for
_linearization_optionsand_optimization_options. Up to this PR, these were defined asdict[str, str | float]with thefloatoption only used on initialisation. As soon as OMC was run, the data would be defined asstr. Always forcingstrremoves this ambiguity and simplifies the definitions. This change is within the same PR as it is needed to get an OK from the linters ...