Skip to content

Conversation

@Shahbaz-dataq
Copy link
Contributor

External References

@Shahbaz-dataq Shahbaz-dataq changed the base branch from develop to mwa/jira/NMS-19092 December 17, 2025 13:35
@Shahbaz-dataq Shahbaz-dataq marked this pull request as ready for review December 17, 2025 15:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces XML with JSON format when creating and updating events in the event configuration system. The changes primarily focus on updating the data flow to use JSON structures while maintaining backward compatibility with XML content for display purposes.

Key Changes:

  • Added JSON structure mapping for event configuration events
  • Updated store methods to use refreshEventConfigEvents instead of direct fetchEventsBySourceId calls
  • Modified tests to verify the new fetch flow with proper source loading sequence

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

File Description
ui/src/mappers/eventConfig.mapper.ts Adds mapEventConfEventFromServer function to transform server events into JSON structure and includes JSON content in mapped events
ui/src/stores/eventConfigDetailStore.ts Changes fetchSourceById to call refreshEventConfigEvents instead of fetchEventsBySourceId
ui/src/containers/EventConfigurationDetail.vue Simplifies mount logic by removing redundant calls and adds debug logging
ui/tests/containers/EventConfigurationDetail.test.ts Updates tests to verify the new source fetching flow and event loading sequence

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@synqotik synqotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shahbaz-dataq Shahbaz-dataq changed the base branch from mwa/jira/NMS-19092 to features/eventconf-json December 23, 2025 17:21
@Shahbaz-dataq Shahbaz-dataq changed the base branch from features/eventconf-json to mwa/jira/NMS-19227 January 2, 2026 14:15
@Shahbaz-dataq Shahbaz-dataq merged commit 2b8bd15 into mwa/jira/NMS-19227 Jan 5, 2026
5 checks passed
@Shahbaz-dataq Shahbaz-dataq deleted the jira/NMS-19094-json-implementation branch January 5, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants