NMS-19227: Extend JSON-Based EventConf Loading and Processing Across All Functionalities. #8208
+994
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Event Configuration Handling
# Conflicts: # opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/EventConfPersistenceService.java
…nts to eliminate manual changes.
…All Functionalities.
There was a problem hiding this comment.
Pull request overview
This PR transitions the event configuration system from XML-based content storage to JSON-based content storage, while maintaining backward compatibility by keeping the XML content field populated alongside the new JSON content field.
- Changed event parsing and serialization from
JaxbUtilstoJsonUtils - Updated database access methods from
getXmlContent()togetContent() - Modified log messages to reflect JSON parsing instead of XML parsing
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| EventConfRestService.java | Updated event download endpoint to parse JSON content instead of XML |
| DefaultEventConfDao.java | Changed event configuration DAO to use JSON parsing for database events |
| EventConfExtensionManager.java | Modified extension manager to use JSON for event comparison and updates while maintaining XML content |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...layer/core/src/main/java/org/opennms/features/apilayer/config/EventConfExtensionManager.java
Show resolved
Hide resolved
# Conflicts: # opennms-model/src/main/java/org/opennms/netmgt/model/EventConfEventDto.java # opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/EventConfPersistenceServiceIT.java
…-19094-json-implementation
mwajahatabbasi
changed the base branch from
mwa/jira/NMS-19092
to
features/eventconf-json
cgorantla
reviewed
Dec 23, 2025
Contributor
cgorantla
left a comment
cgorantla
left a comment
There was a problem hiding this comment.
Build is still failing
… for Event Conf (#8120) * NMS-19227: Fixed Integration Test issues. * NMS-19092: Fixed Integration Test issues. * NMS-19092: Added Severity value while preparing eventConfEventList in EventConfTestUtil. * NMS-19092: Handle PR Review Changes. * Update core/schema/src/main/java/liquibase/ext/opennms/eventconf/EventConfSqlGenerator.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * NMS-19092: Handle PR Review Changes. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 24 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
opennms-model/src/main/java/org/opennms/netmgt/model/EventConfEvent.java
Outdated
Show resolved
Hide resolved
opennms-webapp-rest/src/test/java/org/opennms/web/rest/v2/EventConfPersistenceServiceIT.java
Show resolved
Hide resolved
core/schema/src/main/java/liquibase/ext/opennms/eventconf/EventConfSqlGenerator.java
Show resolved
Hide resolved
mwajahatabbasi
requested review from
cgorantla
and removed request for
cgorantla
NMS-19094: Replace xml with JSON when creating and updating an event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira (Issue Tracker): https://opennms.atlassian.net/browse/NMS-19227