Agility #33
Draft
Agility #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a chance to spawn a Mark of Grace at random tiles when completing obstacles in the Gnome Stronghold Agility Course. The chance increases slightly with the player's Agility level. Also moves the GNOME_AGILITY_STAGE attribute key to the course plugin for better encapsulation.
Introduces a new attribute to track the number of laps a player completes on the Gnome Stronghold Agility Course. Upon course completion, the player's lap count is incremented and displayed in a message.
adds Draynor rooftop agility course
Commented out Mark of Grace spawn on obstacle completion and moved it to lap completion. Improved maybeSpawnMark to prevent duplicate marks on the course. Changed groundItems in World from private to public to allow access for duplicate checking.
Extracted Mark of Grace spawning logic from DraynorRooftopCoursePlugin and GnomeStrongholdCoursePlugin into a new MarkOfGraceService class. Updated both plugins to use the new service, improving code reuse and maintainability.
Moved GnomeStrongholdCoursePlugin and DraynorRooftopCoursePlugin into 'regularcourses' and 'rooftopcourses' subpackages, respectively. Updated package declarations and imports to reflect new structure, improving code organization and maintainability.
need to add lvl checks
todo: - add right animations - right messages - advanced course
This reverts commit 1da0af9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress!
To - Do List
General
Normal Courses
Rooftop Courses
Marks of Grace
General agility stuff
Known Bugs
I can't reach that!needs to be fixed with pathfinding