fix: reset selected stage type when switching tabs#210
Merged
Conversation
OpenSauce
force-pushed
the
fix/tab-switch-stage-selection
branch
from
c0c1027 to
791c3a9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a GUI state issue where switching between Amp and Effects tabs did not update selected_stage_type, causing Add Stage to add a stage from the previously active tab’s category.
Changes:
- On
Message::TabSelected, remap the active tab to aStageCategory(Amp/Effect). - If the stored
selected_stage_typeis from a different category, reset it to the firstStageTypeavailable for the newly selected category.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
OpenSauce
force-pushed
the
fix/tab-switch-stage-selection
branch
from
791c3a9 to
08c5445
Compare
Switching from the Amp tab to the Effects tab (or vice versa) did not update selected_stage_type, so clicking "Add Stage" would add the previously selected stage from the other tab's category.
OpenSauce
force-pushed
the
fix/tab-switch-stage-selection
branch
from
08c5445 to
4921562
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching from the Amp tab to the Effects tab (or vice versa) did not update selected_stage_type, so clicking "Add Stage" would add the previously selected stage from the other tab's category.