Skip to content

Conversation

@AnthonyRonning
Copy link
Contributor

@AnthonyRonning AnthonyRonning commented Oct 28, 2025

Updates opensecret SDK from 0.2.1 to 0.2.2, which adds support for OpenAI-compatible tool calling.

Changes

  • Update opensecret dependency from 0.2.1 to 0.2.2

New Features

The SDK now includes:

  • Tool calling types (Tool, ToolCall, Function, FunctionCall)
  • tools and tool_choice fields in ChatCompletionRequest
  • tool_calls field in ChatMessage and ChatMessageDelta
  • Full support for streaming tool calls

Testing

  • ✅ All pre-commit checks passed
  • ✅ Formatting and linting verified
  • ✅ Tests pass
  • ✅ Manually tested tool calling with both streaming and non-streaming requests

Resolves the issue reported in https://gist.github.com/justinmoon/062f73444cb13ee3a7ea9b981ffb456a

Summary by CodeRabbit

  • Chores
    • Updated OpenSecret SDK dependency to version 0.2.2
    • Updated tracing-subscriber dependency to 0.3.20

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@coderabbitai
Copy link

coderabbitai bot commented Oct 28, 2025

Walkthrough

Updates dependency versions in the project's Cargo.toml: bumps opensecret from 0.2.1 → 0.2.2 and sets tracing-subscriber to 0.3.20. No code, API, or structural changes in source files.

Changes

Cohort / File(s) Summary
Dependency updates
Cargo.toml
Bumped opensecret 0.2.1 → 0.2.2; updated tracing-subscriber to 0.3.20. No other edits to source files or public APIs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single manifest version bumps; verify compatibility matrix if needed.

Possibly related PRs

  • Bump sdk to 0.2.1 #1 — prior bump of opensecret (0.2.0 → 0.2.1), directly related to this subsequent patch update.

Poem

🐇 I nibbled the Cargo, a tidy small chew,
I hopped from 0.2.1 to 0.2.2.
Tracing tuned to 0.3.20’s glow,
A tiny patch breeze with a quiet hello. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Bump SDK to 0.2.2 (adds tool calling support)" accurately captures the main change in the changeset. The raw summary confirms that the opensecret dependency was bumped from 0.2.1 to 0.2.2, and the PR objectives clarify that the primary purpose is to add OpenAI-compatible tool calling support through this SDK update. The title is concise, specific, and clearly communicates the intended change without vague language. A teammate reviewing the git history would immediately understand that this PR introduces tool calling capabilities via an SDK dependency update.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-sdk-0-2-2

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0ceb0a8 and 9fe297d.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
Cargo.toml

📄 CodeRabbit inference engine (CLAUDE.md)

Depend on opensecret version 0.2.0

Files:

  • Cargo.toml
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
PR: OpenSecretCloud/maple-proxy#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-12T18:29:41.802Z
Learning: Applies to Cargo.toml : Depend on opensecret version 0.2.0
📚 Learning: 2025-09-12T18:29:41.802Z
Learnt from: CR
PR: OpenSecretCloud/maple-proxy#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-12T18:29:41.802Z
Learning: Applies to Cargo.toml : Depend on opensecret version 0.2.0

Applied to files:

  • Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build-and-push (linux/arm64, ubuntu-22.04-arm64-4core)
  • GitHub Check: build-and-push (linux/amd64, ubuntu-latest)
  • GitHub Check: Build windows-x86_64
🔇 Additional comments (2)
Cargo.toml (2)

23-23: ⚠️ Verify opensecret version against coding guidelines.

The coding guidelines specify "Depend on opensecret version 0.2.0", but this PR bumps to 0.2.2. While the PR objectives document the need for tool calling support and confirm all tests pass, this represents a significant deviation from the documented requirement.

Clarify whether:

  1. The guideline should be updated to reflect the new requirement for 0.2.2
  2. This is an intentional exception for the tool calling feature
  3. The guideline was outdated and should be refreshed

45-45: Routine patch version update to tracing-subscriber.

The update from 0.3 to 0.3.20 with the env-filter feature is a standard patch version bump and looks appropriate.


Comment @coderabbitai help to get the list of available commands and usage tips.

Updates tracing-subscriber from 0.3.19 to 0.3.20 to address RUSTSEC-2025-0055:
logging user input may result in poisoning logs with ANSI escape sequences.

Also updates related dependencies (matchers, nu-ansi-term) and removes
unused transitive dependencies (overload, winapi).

Note: serde_cbor unmaintained warning (RUSTSEC-2021-0127) comes from
opensecret SDK dependency and will be addressed in a future SDK update.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@AnthonyRonning AnthonyRonning merged commit 17ea7cb into master Oct 28, 2025
15 checks passed
@AnthonyRonning AnthonyRonning deleted the bump-sdk-0-2-2 branch October 28, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants