OIDC/Auth2 integration #2649
Open
OIDC/Auth2 integration #2649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boehlke
added
feature
keycloak-oidc
luisa-beerboom
requested changes
Oct 10, 2024
Member
luisa-beerboom
left a comment
luisa-beerboom
left a comment
There was a problem hiding this comment.
Amend the tests for actions that were updated, delete the tests for actions that were deleted.
Comment on lines
55
to
56
| additional_optional_fields={ | ||
| "saml_attr_mapping": { | ||
| "type": ["object", "null"], | ||
| "properties": saml_props, | ||
| "required": ["saml_id"], | ||
| "additionalProperties": False, | ||
| }, | ||
| }, |
Member
There was a problem hiding this comment.
If it is going to be empty, you can delete the additional_optional_fields attribute.
Comment on lines
-53
to
-59
| def create_authorization_token(self, user_id: int, email: str) -> str: | ||
| try: | ||
| response = self.auth_handler.create_authorization_token(user_id, email) | ||
| except AuthenticateException as e: | ||
| raise AuthenticationException(e.message) | ||
| return response.headers.get(AUTHORIZATION_HEADER, "") | ||
|
|
Member
There was a problem hiding this comment.
openslides_backend/services/auth/interface.py defines the interface for this class, including this method. You should remove the method from that place as well
…ibs locally) is optional
…g Keycloak Admin API connection
# Conflicts: # docs/actions/user.create.md # openslides_backend/action/actions/organization/update.py # openslides_backend/action/actions/user/create.py # requirements/export_service_commits.sh # tests/system/action/organization/test_update.py # tests/system/action/user/test_save_saml_account.py
# Conflicts: # requirements/partial/requirements_production.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a POC for a OIDC/oauth2 integration into OpenSlides. The dev setup is based on keycloak.