Skip to content

Conversation

@hmgaudecker
Copy link
Member

@hmgaudecker hmgaudecker commented Dec 20, 2025

  • use ty instead of mypy. Run with:

    pixi run ty check

  • pre-commits are disabled, I played around a bit with local suggestions as described here, but probably we should just wait for a (semi-)official one to appear.

  • Sort-of unrelated changes (they were actually caught when I had not disabled ty for that notebook): Fix the example in the docs and some test names, which still referred to an old function name

@hmgaudecker hmgaudecker requested a review from timmens December 20, 2025 09:24
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

❌ Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.24%. Comparing base (96d0e54) to head (94e5848).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/dags/dag.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   95.34%   95.24%   -0.10%     
==========================================
  Files          22       22              
  Lines        1073     1073              
==========================================
- Hits         1023     1022       -1     
- Misses         50       51       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@timmens timmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting times, very nice!

@hmgaudecker hmgaudecker merged commit 733ea6c into main Dec 21, 2025
21 checks passed
@hmgaudecker hmgaudecker deleted the ty branch December 21, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants