-
Notifications
You must be signed in to change notification settings - Fork 1
Move from mypy to ty #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
- Coverage 95.34% 95.24% -0.10%
==========================================
Files 22 22
Lines 1073 1073
==========================================
- Hits 1023 1022 -1
- Misses 50 51 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
timmens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very exciting times, very nice!
…e and remove outdated comments.
use ty instead of mypy. Run with:
pixi run ty checkpre-commits are disabled, I played around a bit with local suggestions as described here, but probably we should just wait for a (semi-)official one to appear.
Sort-of unrelated changes (they were actually caught when I had not disabled ty for that notebook): Fix the example in the docs and some test names, which still referred to an old function name