Issue 18 : fix asset name input remove characters sporadically error#20
Open
gargabhay1999 wants to merge 1 commit intomasterfrom
Open
Issue 18 : fix asset name input remove characters sporadically error#20gargabhay1999 wants to merge 1 commit intomasterfrom
gargabhay1999 wants to merge 1 commit intomasterfrom
Conversation
gargabhay1999
requested review from
alexanderbock,
engbergandreas and
micahnyc
alexanderbock
requested review from
dmelancon
and removed request for
alexanderbock,
engbergandreas,
micahnyc and
soniacq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
RCA: setName(name) in method ValidateItemName(name) was resetting the old state variable.
Fix: The call to setName(name) in the validation function is redundant since the name is already updated in handleNameChange method