Remove: Settings NewGRF #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Of limited use with support for base set parameters since OpenTTD 14, so maintenance of little use.
2TallTyler
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The settings NewGRF was an odd hack to allow changing of base graphics set parameters, prior to baseset parameters support having been added in OpenTTD 14. Supporting it adds unnecessary maintenance overhead now baseset parameters are fully supported.
This PR:
pnmlsources and removes the settings NewGRF from the list of NewGRFs to make in makefile.After this is merged, trying to use an old settings NewGRF with OpenGFX2 would just have no effect. In parallel, I would set the Settings NewGRF on BaNaNaS to max OpenTTD version 14, to depreciate it.
I could add a new check in the baseset extra NewGRF to see if the settings NewGRF is being loaded, and inform the user that it's depreciated... But it's such an odd corner case, I'm not inclined to.