Fix critical bugs #273
Open
Fix critical bugs #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix elapsed time reset in opslevelAppendLogProcessor.go: time.Since(time.Now()) always returns ~0, so elapsed never reset. Changed to `s.elapsed = 0` - Use dynamic ImageTagVersion in k8s.go instead of hardcoded v2024.1.3 for the init container image to prevent version mismatches - Fix memory calculation typo in k8s_config.go: 1024*1204 → 1024*1024 (was allocating ~17% more memory than intended) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Move defer cleanup after error checks in k8s.go Run() method Previously, defer was called before error check, causing delete attempts on failed/nil resources - Add sync.RWMutex protection for isLeader variable in leaderElection.go The variable was accessed from multiple goroutines without synchronization Added setLeader()/getLeader() functions for thread-safe access Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jasonopslevel
force-pushed
the
fix-critical-bugs
branch
from
8ec7346 to
bbaa91d
Compare
Tests added:
- TestSetLeaderGetLeader: basic setLeader/getLeader functionality
- TestSetLeaderGetLeader_ConcurrentAccess: race condition verification
- TestSetLeaderGetLeader_ConcurrentReadWrite: simulates callback pattern
- TestDeleteConfigMap_NilSafe, TestDeletePDB_NilSafe, TestDeletePod_NilSafe
- TestGetConfigMapObject, TestGetPBDObject: verify object creation
- TestDeleteFunctions_RequireClientset: documents expected behavior
Additional fixes:
- Add nil guards to DeleteConfigMap, DeletePDB, DeletePod for defensive safety
- Fix log message typo in DeletePDB ("configmap" -> "pod disruption budget")
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jasonopslevel
force-pushed
the
fix-critical-bugs
branch
from
bbaa91d to
a65559e
Compare
jasonopslevel
commented
Jan 21, 2026
| { | ||
| Name: "helper", | ||
| Image: "public.ecr.aws/opslevel/opslevel-runner:v2024.1.3", // TODO: fmt.Sprintf("public.ecr.aws/opslevel/opslevel-runner:v%s", ImageTagVersion), | ||
| Image: fmt.Sprintf("public.ecr.aws/opslevel/opslevel-runner:v%s", ImageTagVersion), |
Contributor
Author
There was a problem hiding this comment.
The goreleaser config doesn't explicitly set ldflags, but goreleaser has default behavior that automatically injects:
-X main.version={{.Version}}
-X main.commit={{.Commit}}
-X main.date={{.Date}}
jasonopslevel
commented
Jan 21, 2026
| @@ -0,0 +1,44 @@ | |||
| # SQLite databases | |||
Contributor
Author
There was a problem hiding this comment.
trying out using beads. This adds a bunch of boilerplate. I can do in a separate MR, but the actual fixes are relatively small.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This fixes some security / correctness issues.
Changelog
changieentryTophatting