This repository was archived by the owner on Jun 3, 2021. It is now read-only.
Conversation
Contributor
|
I think it could be useful to have that crate available. |
matthandlersux
approved these changes
Mar 26, 2019
Contributor
matthandlersux
left a comment
There was a problem hiding this comment.
LGTM. IMO the macro name could be more descriptive, though. something like:
get_enum_field!(
parse_args_safe(vec!["program", "file"].into_iter().map(String::from))?,
Args::Scriptkeeper,
script_path
)
Contributor
|
this is really neat, I would endorse that as a separate crate for sure 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do people think of this? This is using a tiny crate that I came up with yesterday: unsafe_get. We could also just put this into this project. But it seems generally useful. Should I put it on crates.io?
@matthandlersux @jondistad @data-pup @hallettj