Skip to content

Conversation

@gavinbaumanis
Copy link

Description

Postgresql does not auto cast a 0|1 value to FALSE|TRUE - for Boolean types.

This PR changes 0|1 values -> FALSE|TRUE

Jira Issues

Bug Tracker: https://ortussolutions.atlassian.net/browse/CONTENTBOX-1541

Type of change

Please delete options that are not relevant.

  • Bug Fix

Checklist

  • My code follows the style guidelines of this project cfformat
  • [N/A] I have commented my code, particularly in hard-to-understand areas
  • [N/A] I have made corresponding changes to the documentation
  • [N/A] I have added tests that prove my fix is effective or that my feature works
  • [N/A] New and existing unit tests pass locally with my changes

My changes are correct but still fail because QB is "string-ifying" my boolean values from false to "false".

Nonetheless - Here is my PR - once QB is corrected - this PR will be appropriate.

@lmajano
Copy link
Contributor

lmajano commented Apr 7, 2025

This looks good. However, we need to test against MySQL and the other databases.

@gavinbaumanis
Copy link
Author

gavinbaumanis commented Apr 8, 2025 via email

@lmajano
Copy link
Contributor

lmajano commented May 5, 2025

hi @gavinbaumanis we will be back 100% on things next week. Sorry for the delays, but the release of BoxLang and ITB really consumed our time. Hopefully, we can start closing a lot of these tickets soon.

FYI, your image did not come through?

@gavinbaumanis
Copy link
Author

Hi @lmajano
Just thought I would give you a little prompt and see if the underlying issue of Booleans being "stringified" can be looked into, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants