config: Trigger search bar #873
Open
+436
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
💬ko
💬cn
raidboss
|
This is very helpful! |
valarnin
reviewed
Jan 13, 2026
Collaborator
valarnin
left a comment
valarnin
left a comment
There was a problem hiding this comment.
I'll give this a more proper review after I've recovered from week 1 prog since there's a fair chunk of new code here. Hopefully this weekend sometime.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Lee Jaehyuk <alex00728@outlook.com>
Co-authored-by: Lee Jaehyuk <alex00728@outlook.com>
Co-authored-by: Lee Jaehyuk <alex00728@outlook.com>
Collaborator
|
English translations look fine. This is very tailored to config currently. Should it be more generalized to e.g. replace the coverage report search, or be added to raidemulator's trigger output, or elsewhere where we might need to filter like this? In other words, should the logic portion of this (determining which triggers to show) be separated from the display logic? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports both
RaidbossandOopsyraidsy.Multi-word AND search for titles/IDs.